fix row pinning after ungrouping - #6493
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe row-pinning lookup now uses pre-pagination and core row models. Grouped row-pinning tests verify safe grouping removal, temporary omission, preserved pin state, and restoration. ChangesGrouped row pinning
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 5404e05
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Resolve pinned rows directly from the pre-pagination and core row-model maps instead of calling the throwing
table.getRow(id, true)API. Add a regression test covering grouping, pinning a synthetic group row, ungrouping, and regrouping.Fixes #5822.
Why
Ungrouping removes synthetic group rows from the active row models while their IDs may remain in row-pinning state.
getTopRows()andgetBottomRows()treated those temporarily absent IDs as exceptional and crashed. The previous proposed fix in #5823 usedtry/catchfor this expected lookup miss.An absent synthetic row is now omitted without exception-driven control flow. The pinned ID remains in state, so the correct grouped row is restored if the same grouping is applied again.
Validation
pnpm --filter @tanstack/table-core test:lib --run tests/implementation/features/row-pinning/rowPinningFeature.test.tspnpm exec eslint packages/table-core/src/features/row-pinning/rowPinningFeature.utils.ts packages/table-core/tests/implementation/features/row-pinning/rowPinningFeature.test.tspnpm --filter @tanstack/table-core test:typesgit diff --checkSummary by CodeRabbit