Skip to content

chore: tweak prerelease flow#6906

Merged
birkskyum merged 1 commit intomainfrom
chore--tweak-prerelease-flow
Mar 12, 2026
Merged

chore: tweak prerelease flow#6906
birkskyum merged 1 commit intomainfrom
chore--tweak-prerelease-flow

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 12, 2026

let changeset set the npm dist tag

Summary by CodeRabbit

  • Chores
    • Updated release workflow to improve prerelease identification and GitHub Release creation process.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 975524f7-2af7-4396-803d-a1754a7baa17

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2795a and 6340133.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The GitHub Actions release workflow refactors prerelease detection logic by introducing a dedicated prerelease flag. When a branch matches the *-pre pattern, the workflow now explicitly sets prerelease=true instead of relying on tag=next, then passes this flag directly to the release script.

Changes

Cohort / File(s) Summary
GitHub Actions Release Workflow
.github/workflows/release.yml
Refactored prerelease detection to use a dedicated prerelease flag instead of inferring prerelease status from the tag value. Updated the release script invocation to conditionally pass --prerelease based on the prerelease flag rather than checking if dist-tag equals 'next'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A simpler path, we've found today,
With prerelease flags that clearly say,
No need to guess from tags so grand—
Just true or false, you understand!
Our workflows hop with clearer ways,
Through GitHub Actions' sunny days! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: tweak prerelease flow' is partially related to the changeset. It refers to the prerelease flow mentioned in the changes, but is vague about the specific nature of the tweak (refactoring the dist-tag determination logic to use a prerelease flag). Consider a more specific title like 'chore: use prerelease flag instead of dist-tag for release script' to better reflect the actual implementation change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore--tweak-prerelease-flow
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2026

View your CI Pipeline Execution ↗ for commit 6340133

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-12 15:25:15 UTC

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

⚠️ No Changeset found

Latest commit: 6340133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6906

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6906

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6906

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6906

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6906

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6906

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6906

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6906

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6906

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6906

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6906

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6906

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6906

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6906

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6906

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6906

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6906

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6906

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6906

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6906

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6906

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6906

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6906

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6906

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6906

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6906

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6906

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6906

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6906

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6906

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6906

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6906

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6906

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6906

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6906

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6906

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6906

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6906

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6906

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6906

commit: 41aec2e

@github-actions
Copy link
Contributor

Bundle Size Benchmarks

  • Commit: 9f2795a779aa
  • Measured at: 2026-03-12T15:26:25.499Z
  • Baseline source: history:9f2795a779aa
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.09 KiB 0 B (0.00%) 274.11 KiB 75.68 KiB ▁▆▆████████
react-router.full 90.08 KiB 0 B (0.00%) 284.36 KiB 78.32 KiB ▁▃▃████████
solid-router.minimal 36.42 KiB 0 B (0.00%) 109.29 KiB 32.74 KiB ▁▅▅████████
solid-router.full 40.75 KiB 0 B (0.00%) 122.27 KiB 36.58 KiB ▁▅▅████████
vue-router.minimal 52.29 KiB 0 B (0.00%) 149.34 KiB 47.01 KiB ▁▅▅████████
vue-router.full 57.08 KiB 0 B (0.00%) 164.85 KiB 51.27 KiB ▁▅▅████████
react-start.minimal 99.66 KiB 0 B (0.00%) 313.26 KiB 86.22 KiB ▁▆▆████████
react-start.full 102.97 KiB 0 B (0.00%) 322.99 KiB 89.07 KiB ▁▄▄████████
solid-start.minimal 48.75 KiB 0 B (0.00%) 146.89 KiB 43.14 KiB ▁▄▄████████
solid-start.full 54.21 KiB 0 B (0.00%) 162.75 KiB 47.88 KiB ▁▅▅████████

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing chore--tweak-prerelease-flow (6340133) with main (9f2795a)

Open in CodSpeed

@birkskyum birkskyum merged commit 576b5ac into main Mar 12, 2026
15 checks passed
@birkskyum birkskyum deleted the chore--tweak-prerelease-flow branch March 12, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant