Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AnyMiddleware typings (createServerFn, with middleware) #2773

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

kddige
Copy link
Contributor

@kddige kddige commented Nov 15, 2024

AnyMiddleware had a strict requirement on AnyValidator that broke middleware types with serverFn.

Was introduced in: 4d7c669

closes: #2769

AnyMiddleware had a hard constraint on AnyValidator, making it un-useable when passing middlewares to a serverFn
Copy link

nx-cloud bot commented Nov 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9c46b10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2773

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2773

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2773

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2773

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2773

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2773

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2773

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2773

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2773

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2773

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2773

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2773

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2773

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2773

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2773

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2773

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2773

commit: 9c46b10

@schiller-manuel schiller-manuel merged commit c792e77 into TanStack:main Nov 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect types and missing context issues with middleware
2 participants