fix(react-query): allow retryOnMount when throwOnError is function (#9336) #9338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases When throwOnError is a function, allow retryOnMount to proceed even when error boundary hasn't reset, while maintaining the prevention behavior for boolean throwOnError values.
TkDodo
reviewed
Jun 30, 2025
| options.experimental_prefetchInRender | ||
| ) { | ||
| // Prevent retrying failed query if the error boundary has not been reset yet | ||
| if (!errorResetBoundary.isReset()) { | ||
| options.retryOnMount = false | ||
| } | ||
| } else if (options.throwOnError) { | ||
| if (!errorResetBoundary.isReset() && typeof options.throwOnError !== 'function') { |
There was a problem hiding this comment.
The function can return true or false so I think we'd need to evaluate it to get the result
There was a problem hiding this comment.
Updated to evaluate the throwOnError function result instead of just checking if it's a function. Thanks for the feedback!
Refine behavior to handle function-type throwOnError, allowing retries when appropriate. Ensure boolean throwOnError values still prevent retries when the error boundary isn't reset.
This commit introduces tests to verify the behavior of the `throwOnError` callback in scenarios where `retryOnMount` is enabled. It ensures proper handling of retries based on the error state and the `throwOnError` function's return value. These tests improve the reliability and coverage of error handling logic in `useQuery`.
- Pass query object to ensurePreventErrorBoundaryRetry for accurate state checking - Preserve query deduplication behavior while fixing throwOnError function handling - Fixes issue where throwOnError function couldn't access query error state
Han5991
force-pushed
the
fix/usequery-retry-on-mount-with-throw-on-error-issue(#9336)
branch
from
f7b90c2 to
9c8516d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #9336
Summary