Skip to content

refactor: integrate util "noop" function in each packages #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular-query-experimental/src/inject-mutation.ts
Original file line number Diff line number Diff line change
@@ -12,11 +12,11 @@ import {
import {
MutationObserver,
QueryClient,
noop,
notifyManager,
shouldThrowError,
} from '@tanstack/query-core'
import { signalProxy } from './signal-proxy'
import { noop } from './util'
import type { DefaultError, MutationObserverResult } from '@tanstack/query-core'
import type { CreateMutateFunction, CreateMutationResult } from './types'
import type { CreateMutationOptions } from './mutation-options'
3 changes: 1 addition & 2 deletions packages/angular-query-experimental/src/providers.ts
Original file line number Diff line number Diff line change
@@ -7,10 +7,9 @@ import {
effect,
inject,
} from '@angular/core'
import { QueryClient, onlineManager } from '@tanstack/query-core'
import { QueryClient, noop, onlineManager } from '@tanstack/query-core'
import { isPlatformBrowser } from '@angular/common'
import { isDevMode } from './util/is-dev-mode/is-dev-mode'
import { noop } from './util'
import type { Provider } from '@angular/core'
import type {
DevtoolsButtonPosition,
1 change: 0 additions & 1 deletion packages/angular-query-experimental/src/util/index.ts

This file was deleted.

1 change: 1 addition & 0 deletions packages/query-async-storage-persister/package.json
Original file line number Diff line number Diff line change
@@ -59,6 +59,7 @@
"!src/__tests__"
],
"dependencies": {
"@tanstack/query-core": "workspace:*",
"@tanstack/query-persist-client-core": "workspace:*"
},
"devDependencies": {
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { noop } from './utils'
import { noop } from '@tanstack/query-core'

interface AsyncThrottleOptions {
interval?: number
2 changes: 1 addition & 1 deletion packages/query-async-storage-persister/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { noop } from '@tanstack/query-core'
import { asyncThrottle } from './asyncThrottle'
import { noop } from './utils'
import type {
AsyncStorage,
MaybePromise,
3 changes: 0 additions & 3 deletions packages/query-async-storage-persister/src/utils.ts

This file was deleted.

2 changes: 1 addition & 1 deletion packages/query-sync-storage-persister/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { noop } from './utils'
import { noop } from '@tanstack/query-core'
import type {
PersistRetryer,
PersistedClient,
3 changes: 0 additions & 3 deletions packages/query-sync-storage-persister/src/utils.ts

This file was deleted.

3 changes: 1 addition & 2 deletions packages/solid-query/src/useMutation.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { MutationObserver, shouldThrowError } from '@tanstack/query-core'
import { MutationObserver, noop, shouldThrowError } from '@tanstack/query-core'
import { createComputed, createMemo, on, onCleanup } from 'solid-js'
import { createStore } from 'solid-js/store'
import { useQueryClient } from './QueryClientProvider'
import { noop } from './utils'
import type { DefaultError } from '@tanstack/query-core'
import type { QueryClient } from './QueryClient'
import type {
5 changes: 2 additions & 3 deletions packages/solid-query/src/useQueries.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { QueriesObserver } from '@tanstack/query-core'
import { QueriesObserver, noop } from '@tanstack/query-core'
import { createStore, unwrap } from 'solid-js/store'
import {
batch,
@@ -13,7 +13,6 @@ import {
} from 'solid-js'
import { useQueryClient } from './QueryClientProvider'
import { useIsRestoring } from './isRestoring'
import { noop } from './utils'
import type { SolidQueryOptions, UseQueryResult } from './types'
import type { Accessor } from 'solid-js'
import type { QueryClient } from './QueryClient'
@@ -292,7 +291,7 @@ export function useQueries<
})
})

let unsubscribe = noop
let unsubscribe: () => void = noop
createComputed<() => void>((cleanup) => {
cleanup?.()
unsubscribe = isRestoring() ? noop : subscribeToObserver()
1 change: 0 additions & 1 deletion packages/solid-query/src/utils.ts

This file was deleted.

4 changes: 2 additions & 2 deletions packages/svelte-query/src/createBaseQuery.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { derived, get, readable } from 'svelte/store'
import { notifyManager } from '@tanstack/query-core'
import { noop, notifyManager } from '@tanstack/query-core'
import { useIsRestoring } from './useIsRestoring.js'
import { useQueryClient } from './useQueryClient.js'
import { isSvelteStore, noop } from './utils.js'
import { isSvelteStore } from './utils.js'
import type {
QueryClient,
QueryKey,
4 changes: 2 additions & 2 deletions packages/svelte-query/src/createMutation.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { derived, get, readable } from 'svelte/store'
import { MutationObserver, notifyManager } from '@tanstack/query-core'
import { MutationObserver, noop, notifyManager } from '@tanstack/query-core'
import { useQueryClient } from './useQueryClient.js'
import { isSvelteStore, noop } from './utils.js'
import { isSvelteStore } from './utils.js'
import type {
CreateMutateFunction,
CreateMutationOptions,
4 changes: 2 additions & 2 deletions packages/svelte-query/src/createQueries.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { QueriesObserver, notifyManager } from '@tanstack/query-core'
import { QueriesObserver, noop, notifyManager } from '@tanstack/query-core'
import { derived, get, readable } from 'svelte/store'
import { useIsRestoring } from './useIsRestoring.js'
import { useQueryClient } from './useQueryClient.js'
import { isSvelteStore, noop } from './utils.js'
import { isSvelteStore } from './utils.js'
import type { Readable } from 'svelte/store'
import type { StoreOrVal } from './types.js'
import type {
2 changes: 0 additions & 2 deletions packages/svelte-query/src/utils.ts
Original file line number Diff line number Diff line change
@@ -6,5 +6,3 @@ export function isSvelteStore<T extends object>(
): obj is Readable<T> {
return 'subscribe' in obj && typeof obj.subscribe === 'function'
}

export function noop(): void {}
86 changes: 3 additions & 83 deletions pnpm-lock.yaml

Large diffs are not rendered by default.