fix(query-core): use performance instead of Date.now to initialize mutationId#8315
Closed
ali-idrizi wants to merge 4 commits into
Closed
fix(query-core): use performance instead of Date.now to initialize mutationId#8315ali-idrizi wants to merge 4 commits into
ali-idrizi wants to merge 4 commits into
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit efbf935. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
TkDodo
reviewed
Nov 20, 2024
Comment on lines
+13
to
+14
| "react": "19.0.0-rc-7ac8e612-20241113", | ||
| "react-dom": "19.0.0-rc-7ac8e612-20241113", |
Collaborator
There was a problem hiding this comment.
can we please use 19.0.0-rc.1, and use it everywhere. I’d really like to have the versions streamlined, thanks 🙏
TkDodo
reviewed
Nov 20, 2024
ali-idrizi
force-pushed
the
fix/nextjs-date-now
branch
from
0ef3c9e to
efbf935
Compare
This reverts commit db9104b.
ali-idrizi
force-pushed
the
fix/nextjs-date-now
branch
from
9d8fece to
e6cf50e
Compare
|
Any update on this? |
Collaborator
|
we have a second PR open that solves the issue in a different way, so we have to decide which one is going to make it. |
Collaborator
|
we’ll handle this with #8451 without the performance API, as this might also be excluded from prerenders in the future. see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
MutationCache.#mutationIdwas initialized withDate.now(). When usingdynamicIowith Next it was throwing:The error is fixed by using
performance.timeOrigin + performance.now()instead.I have updated the
nextandreactdependencies on the Next 15 integration and example from RC to stable. However, thedynamicIois still an experimental feature and requires the canary dependency, so this not tested. I can confirm that the error was thrown locally byreact-next-15integration when enablingdynamicIo, and this change fixes it.Closes #8277