Conversation
…type-checks inside a whole-options getter
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 2185839
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview14 package(s) bumped directly, 11 bumped as dependents. 🟥 Major bumps
|
Contributor
size-limit report 📦
|
…ry-skiptoken-getter-typecheck # Conflicts: # packages/angular-query-experimental/src/__tests__/query-options.test-d.ts
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
injectQuery's whole-options getter (injectQuery(() => ({ ... }))) fails to type-check thequeryFn: cond ? fn : skipTokenpattern.SkipTokenis aunique symbol, and inside the getter's body the ternary'sskipTokenbranch is widened to plainsymbol, which then matches noinjectQueryoverload.CreateQueryOptions(types.ts) now acceptssymbolforqueryFn, following the existingSkipTokenForUseQueriesprecedent invue-query'suseQueries.ts. To replace thequeryFnproperty, it changes from aninterfaceto atypealias overOmitKeyof<CreateBaseQueryOptions, 'suspense' | 'queryFn'>.queryOptions()'sUndefinedInitialDataOptionsoverload (query-options.ts) narrowsqueryFnback toQueryFunction | SkipTokenin its return type, so the widenedsymboldoes not leak to callers.UnusedSkipTokenOptions['queryFn']is nowQueryFunctiondirectly, sinceExclude<..., SkipToken | undefined>no longer filters out the widenedsymbol.injectQuery's implementation casts its options getter to() => CreateBaseQueryOptionswhen callingcreateBaseQuery, which still expects the narrow type.Type-only fix; no runtime behavior changes.
Tests:
inject-query.test-d.ts:datanarrows tostring | undefinedfor a conditionalskipTokeninside a whole-options getter.inject-query.test.ts: the query does not fetch whilequeryFnisskipToken, and fetches once it is replaced.query-options.test-d.ts:UnusedSkipTokenOptionsstill rejectsskipToken.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact