fix(preact-query/useQueries): keep unsubscribed idle by sukvvon · Pull Request #11315 · TanStack/query

sukvvon · 2026-08-27T11:13:55Z

🎯 Changes

useQueries unconditionally set _optimisticResults = 'optimistic' for every query, ignoring the top-level subscribed option. This meant unsubscribed queries showed an optimistic fetching state instead of idle. Same defect as @tanstack/react-query's #11130 — @tanstack/preact-query's useQueries.ts had the identical pattern and needed the same fix.

Now _optimisticResults is undefined when subscribed is false, matching the behavior already used for shouldSubscribe.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Fixed useQueries to avoid showing an optimistic fetching state when queries are unsubscribed.
- Unsubscribed queries now remain idle, do not execute query functions, and do not register observers.
Tests
- Added coverage verifying the correct behavior for queries configured with subscribed: false.

nx-cloud · 2026-08-27T11:14:21Z

View your CI Pipeline Execution ↗ for commit 1e62bda

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 2s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-27 11:22:27 UTC

coderabbitai · 2026-08-27T11:14:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 86cb98fe-6f2e-439e-ac9a-b6896d2f27f4

📥 Commits

Reviewing files that changed from the base of the PR and between 1e62bda and 588eb8d.

📒 Files selected for processing (1)

.changeset/soft-cats-drum.md

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/soft-cats-drum.md

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

useQueries now avoids optimistic fetching and observer subscriptions when subscribed: false. A regression test verifies idle fetching state, no query execution, and no registered observers. A patch changeset records the fix for @tanstack/preact-query.

Changes

Unsubscribed useQueries behavior

Layer / File(s)	Summary
Subscription state and optimistic results `packages/preact-query/src/useQueries.ts`	`useQueries` derives the `subscribed` value once. It disables optimistic results and skips the external-store subscription when `subscribed: false`.
Regression coverage and release metadata `packages/preact-query/src/__tests__/useQueries.test.tsx`, `.changeset/soft-cats-drum.md`	The test verifies no query execution, no observers, `isFetching: false`, and `fetchStatus: idle`. The changeset declares a patch release.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 588eb

This localized change makes unsubscribed queries remain idle and includes tests and release metadata; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the primary fix: keeping unsubscribed `useQueries` idle.
Description check	✅ Passed	The description follows the required template, explains the defect and fix, completes the checklist, and documents the changeset for published code.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/preact-query-useQueries-unsubscribed-idle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-27T11:15:05Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/preact-query`	5.102.7 → 5.102.8	Changeset
`@tanstack/angular-query-experimental`	5.102.7 → 5.102.8	Dependent
`@tanstack/angular-query-persist-client`	5.102.7 → 5.102.8	Dependent
`@tanstack/eslint-plugin-query`	5.102.7 → 5.102.8	Dependent
`@tanstack/lit-query`	0.2.19 → 0.2.20	Dependent
`@tanstack/preact-query-devtools`	5.102.7 → 5.102.8	Dependent
`@tanstack/preact-query-persist-client`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-async-storage-persister`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-broadcast-client-experimental`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-core`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-devtools`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-persist-client-core`	5.102.7 → 5.102.8	Dependent
`@tanstack/query-sync-storage-persister`	5.102.7 → 5.102.8	Dependent
`@tanstack/react-query`	5.102.7 → 5.102.8	Dependent
`@tanstack/react-query-devtools`	5.102.7 → 5.102.8	Dependent
`@tanstack/react-query-next-experimental`	5.102.7 → 5.102.8	Dependent
`@tanstack/react-query-persist-client`	5.102.7 → 5.102.8	Dependent
`@tanstack/solid-query`	5.102.7 → 5.102.8	Dependent
`@tanstack/solid-query-devtools`	5.102.7 → 5.102.8	Dependent
`@tanstack/solid-query-persist-client`	5.102.7 → 5.102.8	Dependent
`@tanstack/svelte-query`	6.1.47 → 6.1.48	Dependent
`@tanstack/svelte-query-devtools`	6.1.47 → 6.1.48	Dependent
`@tanstack/svelte-query-persist-client`	6.1.47 → 6.1.48	Dependent
`@tanstack/vue-query`	5.102.7 → 5.102.8	Dependent
`@tanstack/vue-query-devtools`	6.1.47 → 6.1.48	Dependent

pkg-pr-new · 2026-08-27T11:16:43Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11315

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11315

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11315

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11315

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11315

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11315

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11315

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11315

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11315

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11315

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11315

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11315

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11315

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11315

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11315

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11315

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11315

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11315

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11315

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11315

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11315

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11315

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11315

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11315

commit: 588eb8d

github-actions · 2026-08-27T11:17:05Z

size-limit report 📦

Path	Size
react full	11.89 KB (0%)
react minimal	8.85 KB (0%)

sukvvon changed the title ~~fix(preact-query): don't show optimistic fetching for unsubscribed useQueries~~ fix(preact-query): keep unsubscribed useQueries idle Aug 27, 2026

sukvvon changed the title ~~fix(preact-query): keep unsubscribed useQueries idle~~ fix(preact-query/useQueries): keep unsubscribed useQueries idle Aug 27, 2026

sukvvon self-assigned this Aug 27, 2026

sukvvon force-pushed the fix/preact-query-useQueries-unsubscribed-idle branch from 1e62bda to 3b6dd9e Compare August 27, 2026 11:17

sukvvon changed the title ~~fix(preact-query/useQueries): keep unsubscribed useQueries idle~~ fix(preact-query/useQueries): keep unsubscribed idle Aug 27, 2026

fix(preact-query/useQueries): keep unsubscribed idle

588eb8d

sukvvon force-pushed the fix/preact-query-useQueries-unsubscribed-idle branch from 3b6dd9e to 588eb8d Compare August 27, 2026 11:17

sukvvon requested a review from TkDodo August 27, 2026 11:18

TkDodo approved these changes Aug 27, 2026

View reviewed changes

sukvvon merged commit 6c27607 into main Aug 27, 2026
9 checks passed

sukvvon deleted the fix/preact-query-useQueries-unsubscribed-idle branch August 27, 2026 12:02

github-actions Bot mentioned this pull request Aug 27, 2026

ci: Version Packages #11316

Merged

Navigation Menu

Uh oh!

Uh oh!

fix(preact-query/useQueries): keep unsubscribed idle - #11315

fix(preact-query/useQueries): keep unsubscribed idle#11315
sukvvon merged 1 commit into
mainfrom
fix/preact-query-useQueries-unsubscribed-idle

sukvvon commented Aug 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 27, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

pkg-pr-new Bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sukvvon commented Aug 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Aug 27, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Aug 27, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Aug 27, 2026 •

edited

Loading

coderabbitai Bot commented Aug 27, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 27, 2026 •

edited

Loading