Add initial Data preparing for SSR support #127
Conversation
|
| * Initial data for server-side rendering | ||
| * Allows hydration from server-loaded data | ||
| */ | ||
| initialData?: Array<T> |
There was a problem hiding this comment.
I'll have to think about this more but I don't think collections in general will want an initialData option. TanStack Query is around conventions for you directly managing a client cache. TanStack DB aims to be a bit higher-level where these collection types take over managing the cache for you.
So in this world, the QueryCollection might have an initialData option but not necessarily other collections (e.g. Electric wouldn't).
There was a problem hiding this comment.
I think we'll probably just want an API which awaits running a query (i.e. all the collections are loaded and the query runs). So combination of TanStack/query#9135 & #129
There was a problem hiding this comment.
yes that makes sense for electric.
If there's an api which awaits running a query, would that just be a similar api to the the react query ssr hydration and rehydration?
https://tanstack.com/query/latest/docs/framework/react/guides/advanced-ssr
There was a problem hiding this comment.
If there's an api which awaits running a query, would that just be a similar api to the the react query ssr hydration and rehydration?
Yeah exactly. Our general API goal is to copy TanStack Query directly whenever possible.
There was a problem hiding this comment.
looks like TanStack Query uses initial data as well. still remove initial data?
https://tanstack.com/query/latest/docs/framework/react/guides/ssr
There was a problem hiding this comment.
Yeah, we can add it back later if people ask.
|
The refactors are done if you'd like to pick things up again! |
Hey guys I had a stab at implementing initial data as a first step for SSR support. I can do hydration provider etc similar to tanstack query in a separate pull request.