Default grouped tooltips to visual order - #30
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGrouped tooltip rows now default to visual mark order. X-groups sort top-to-bottom, and y-groups sort left-to-right. The ChangesTooltip ordering
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/charts-core/docs/reference/focus-and-interaction.md`:
- Line 141: Update the corresponding public documentation in the root docs/
tree, not the generated package copies: regenerate the default sort table entry,
visual-ordering policy description, and grouped-ordering guidance corresponding
to packages/charts-core/docs/reference/focus-and-interaction.md lines 141 and
194-196 and packages/charts-core/docs/guides/tooltips-and-focus.md lines
102-107, then run pnpm docs:sync to update all generated copies.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ed6fa79d-c178-43d0-bea7-547dae58b4b0
📒 Files selected for processing (9)
.changeset/visual-tooltip-order.mdAPI-FRICTION.mddocs/guides/tooltips-and-focus.mddocs/reference/focus-and-interaction.mdpackages/charts-core/docs/guides/tooltips-and-focus.mdpackages/charts-core/docs/reference/focus-and-interaction.mdpackages/charts-core/src/runtime.test.tspackages/charts-core/src/tooltip.tspackages/charts-core/src/types.ts
| | `portal` | None | Optional top-layer or fixed-position transport | | ||
| | `items` | Automatic x/y | Ordered rows for a single focused point | | ||
| | `sort` | `color-domain` | Grouped row order | | ||
| | `sort` | `visual` | Grouped row order | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the documentation synchronization workflow for both generated copies.
Apply the public documentation changes only in the corresponding files under docs/, then run pnpm docs:sync.
packages/charts-core/docs/reference/focus-and-interaction.md#L141-L141: regenerate the defaultsorttable entry.packages/charts-core/docs/reference/focus-and-interaction.md#L194-L196: regenerate the visual-ordering policy description.packages/charts-core/docs/guides/tooltips-and-focus.md#L102-L107: regenerate the grouped-ordering guidance.
As per coding guidelines, docs/**: Author public documentation only in the root docs/ tree; do not directly edit packages/charts-core/docs or either llms.txt file because those copies are generated by pnpm docs:sync.
📍 Affects 2 files
packages/charts-core/docs/reference/focus-and-interaction.md#L141-L141(this comment)packages/charts-core/docs/reference/focus-and-interaction.md#L194-L196packages/charts-core/docs/guides/tooltips-and-focus.md#L102-L107
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/charts-core/docs/reference/focus-and-interaction.md` at line 141,
Update the corresponding public documentation in the root docs/ tree, not the
generated package copies: regenerate the default sort table entry,
visual-ordering policy description, and grouped-ordering guidance corresponding
to packages/charts-core/docs/reference/focus-and-interaction.md lines 141 and
194-196 and packages/charts-core/docs/guides/tooltips-and-focus.md lines
102-107, then run pnpm docs:sync to update all generated copies.
Source: Coding guidelines
1 participant
Summary
visualas an explicit sort policy while preserving color-domain, focus, and comparator sortingRelease impact
Includes a minor Changesets entry for
@tanstack/charts; the fixed release group will version together.Validation
pnpm validateSummary by CodeRabbit
New Features
visualtooltip sorting option.Documentation
Tests