-
-
Notifications
You must be signed in to change notification settings - Fork 91
[WIP] feat: live api adapter setup #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| * - TModel: The specific model name (e.g., 'liveAPI-1') | ||
| * - TProviderOptions: Provider-specific options (already resolved) | ||
| */ | ||
| export interface LiveAPIAdapter< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call it RealtimeAdapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think just the ones in activities module or also the ones for gemini specific inside ai-gemini module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so for example this inheritance class: https://github.com/TanStack/ai/pull/189/changes#diff-4092139804ff5293f4635d3c7ef1b5223dda315f2a6ccc686b4b8c010788d876R35
should rather be GeminiLiveAPIAdapter or GeminiRealtimeAdapter?
Personally I would use Realtime everywhere to keep semantics the same
|
Hi, I was working on something similar. How do you plan to add connection parts between server and client parts? I was trying to add a websocket connection between client and server so that client can listen audio from user, send it to server and play the incoming audio. Are you planning on adding something similar? |
I was thinking about adding support for websockets or webrtc connection, but for now I would focus on adding adapters for high level integrations like |
π― Changes
This PR introduces Live API adapters setup.
β Checklist
pnpm run test:pr.π Release Impact