Skip to content

fix(QTDI-1656): what is a processor #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thboileau
Copy link

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

@@ -76,7 +76,7 @@ The component type is declared in the component class. When you import your proj

*Processor*/*Output* components can be:
Copy link
Author

@thboileau thboileau Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, this is not clear at all. and the whole chapter should be rephrased.

I expect an answer to the following question: what are the characteristics of a Processor? What's the contract?
And I see two characteristics:

  • a class with a @Processor annotation that allows to name the processor.
  • a mandatory method annotated @ElementListener with an input record and and output record.

Then, what's the purpose to mention Combiner which is an answer to another question: What is not a processor or an output?

Then it is not clear what are the characteristics of an output? There is just no answer to this question. If we want to say that a processor can serve as an output, we must add what are the differences between processor and output.

Another point related to the previous comment, the documentation does not mention clearly another aspect of components: how to link them.
From my current understanding, there are two kind of links:

  • records that can be generated by an input component, a processor. the second component is "activated" when a record is generated, and it should be either a processor or an output component
  • "subjob" links (OK or KO): the second component is activated when the first one is over. second component could whatever that can start without record: input or standalone components.

Copy link

sonar-eks bot commented Jun 13, 2025

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (56.40% Estimated after merge)
  • Duplications No duplication information (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant