Skip to content

fix(QTDI-1656): useless content type #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(QTDI-1656): useless content type #1055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e6fc1
Update tutorial-create-components-rest-api.adoc
thboileau Apr 16, 2025
1a42777
Merge branch 'master' into thboileau-patch-1
thboileau Apr 25, 2025
801159a
Merge branch 'master' into tboileau/QTDI-1656_useless-content-type
thboileau Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ...ion/src/main/antora/modules/ROOT/pages/tutorial-create-components-rest-api.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ public interface SearchClient extends HttpClient { <1>

@Request(path = "api/v2/search.json", method = "GET") <2>
Response<JsonObject> search(@Header("Authorization") String auth,<3> <4>
@Header("Content-Type") String contentType, <5>
@Query("query") String query, <6>
@Query("query") String query, <5>
@Query("sort_by") String sortBy,
@Query("sort_order") String sortOrder,
@Query("page") Integer page
Expand All @@ -47,8 +46,7 @@ The method return type is a JSON object: `Response<JsonObject>`. The `Response`
The response body is decoded according to the content type returned by the API. The component framework provides the codec to decode JSON content. +
If you want to consume specific content types, you need to specify your custom codec using the `@Codec` annotation.
<4> The `Authorization` HTTP request header allows to provide the authorization token.
<5> Another HTTP request header defined to provide the content type.
<6> Query parameters are defined using the `@Query` annotation that provides the parameter name.
<5> Query parameters are defined using the `@Query` annotation that provides the parameter name.

No additional implementation is needed for the interface, as it is provided by the component framework, according to what is defined above.

Expand Down Expand Up @@ -249,8 +247,7 @@ public class SearchSource implements Serializable {

<6>
private JsonObject search(String auth, String query, String sortBy, String sortOrder, Integer page) {
final Response<JsonObject> response = searchClient.search(auth, "application/json",
query, sortBy, sortOrder, page);
final Response<JsonObject> response = searchClient.search(auth, query, sortBy, sortOrder, page);
if (response.status() == 200 && response.body().getInt("count") != 0) {
return response.body();
}
Expand Down
Loading