Skip to content

chore(QTDI-1484):Add documentation for QTDI-1305 Improve error handling #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yyin-talend
Copy link
Collaborator

…tries

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

This comment has been minimized.

@yyin-talend yyin-talend requested a review from undx May 19, 2025 08:10
Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

This comment has been minimized.

Copy link
Contributor

@ypiel-talend ypiel-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.



=== Connector Implementation
To support it, the input component call EntryImpl.BuilderImpl..withErrorCapable(true), and builder.with() API as the following code did:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double '.' BuilderImpl..withErrorCapable

String errorMessage = ageEntry.getErrorMessage();
String errorFallbackValue = ageEntry.getErrorFallbackValue();
// Do something with the error value, error message, and error fallback value.
Integer age = record.get(Integer.class, "age");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inform that when you retrieve the value of an entry in error, it will returns null. In the example 'age' is null.

Copy link

sonar-eks bot commented May 22, 2025

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (56.40% Estimated after merge)
  • Duplications No duplication information (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants