This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
removed aws access/secret keys #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no need to define them in Terraform files
…om terraform.tfvars
|
Nice! I jumped the shark and started my project to pass libfoo.so files over the wire and execute them on Lambda: https://github.com/chadbrewbaker/lambda-dlopen Why bother uploading your code into AWS Lambda when you can just pass the code you want to execute on demand? |
|
Thanks for the PR. I'll take a look next week :) |
|
It was a really long week. |
|
Hey @mateusfccp you know that time may expand dramatically in Open Source... There is no place for such sarcasm here. With ❤️ |
|
@jmaupetit Sorry, man, I was only joking. No intention to offend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TailorDev this is a great repo for getting started with Lambda and Terraform. I just noticed some unnecessary bits and removed them: the aws access/secret keys.
If the AWS CLI is setup properly, Terraform will pull these credentials out of the environment. At that point there is no need to have users (new to AWS/Terraform) put their credentials in a repo that has the potential to be committed.