Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

removed aws access/secret keys #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

todd-dsm
Copy link

@TailorDev this is a great repo for getting started with Lambda and Terraform. I just noticed some unnecessary bits and removed them: the aws access/secret keys.

If the AWS CLI is setup properly, Terraform will pull these credentials out of the environment. At that point there is no need to have users (new to AWS/Terraform) put their credentials in a repo that has the potential to be committed.

@chadbrewbaker
Copy link

Nice! I jumped the shark and started my project to pass libfoo.so files over the wire and execute them on Lambda: https://github.com/chadbrewbaker/lambda-dlopen

Why bother uploading your code into AWS Lambda when you can just pass the code you want to execute on demand?

@willdurand
Copy link
Member

Thanks for the PR. I'll take a look next week :)

@mateusfccp
Copy link

mateusfccp commented Jul 20, 2018

It was a really long week.

@jmaupetit
Copy link
Member

Hey @mateusfccp you know that time may expand dramatically in Open Source... There is no place for such sarcasm here. With ❤️

@mateusfccp
Copy link

@jmaupetit Sorry, man, I was only joking. No intention to offend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants