Skip to content

perf: Optimize page loading #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheBobBobs
Copy link

Summary

Change search_library to only fetch entry.id.
Add get_tag_entries method to Library. Returns a dict[tag_id, set[entry_ids]]
Change update_thumbs to not fetch all tags for entries on page and instead use the above method to only check the tags it cares about.
move signal connection for item_thumb out of update_thumbs and into its init method.

This brings page load from 200ms->4ms

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added TagStudio: Search The TagStudio search engine Type: Performance An issue or change related to performance labels Jun 12, 2025
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Jun 12, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed A review of this is needed TagStudio: Search The TagStudio search engine Type: Performance An issue or change related to performance
Projects
Status: 🏓 Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants