perf: Optimize page loading #954
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change
search_library
to only fetchentry.id
.Add
get_tag_entries
method to Library. Returns adict[tag_id, set[entry_ids]]
Change
update_thumbs
to not fetch all tags for entries on page and instead use the above method to only check the tags it cares about.move signal connection for
item_thumb
out ofupdate_thumbs
and into its init method.This brings page load from 200ms->4ms
Tasks Completed