perf: optimize sql for or queries #948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
TagStudio: Search
There was a problem hiding this comment.
Works for me and runs on this library in ~13s instead of ~27s.
Comment on lines
-91
to
-96
| # If there is just one tag id, check the normal way | ||
| elif len(tag_ids) == 1: | ||
| bool_expressions.append( | ||
| self.__entry_satisfies_expression(TagEntry.tag_id == tag_ids[0]) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Why did you remove this?
There was a problem hiding this comment.
In my testing using __entry_has_all_tags was slightly faster with one tag id. Sqlite will optimize out the group_by when just one tag_id is present. this can be checked with the query plan
rows = session.execute(text(f"EXPLAIN QUERY PLAN {query_full}")).fetchall()
for row in rows:
print(row)
Computerdores
approved these changes
Jun 5, 2025
Computerdores
moved this from 🏓 Ready for Review
to 🍃 Pending Merge
in TagStudio Development
This query takes 3 minutes for me on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently there is one check for each term in an OrList. This change will extract the tags out of the OrList and put them in one check which is then combined with the remaining terms in the OrList.
Parent tags that expand to many children tags also benefit from this optimization.
Tasks Completed