refactor(ui): merge various tag/tag-like widgets into single Capsule widget - #1520
Merged
Merged
Conversation
CyanVoxel
added
Type: Refactor
CyanVoxel
force-pushed
the
refactor/tag-widget-mvc
branch
from
September 30, 2026 01:36
7f2dfab to
6506f79
Compare
CyanVoxel
removed
the
Status: Blocked
CyanVoxel
marked this pull request as ready for review
September 30, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges the
TagWidget,TagColorPreview,TagColorLabel,FieldTemplateWidget, and weirdModifiedTagWidgetclasses into a the new MVC-splitCapsule/CapsuleViewpair of classes. And also gets rid of the (apparantly) unusedTagAliasWidgetclass.A majority of these classes' code has been duplicated since the initial release, and this new
Capsuleclass acts as a generic tag-like widget that can be easily reused in all of the areas in which these previous classes were used.Tasks Completed