feat: added trigger to prevent a tag to be its own parent #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustyNova016
commented
Sep 5, 2025
| """Add a trigger to prevent having a tag being its own parent""" | ||
| add_trigger = text( | ||
| """ | ||
| CREATE TRIGGER `trigger_before_insert_tag_parents` BEFORE INSERT ON `tag_parents` BEGIN |
There was a problem hiding this comment.
Forgot FOR EACH ROW...
And updates
CyanVoxel
added
Type: Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a trigger to prevent inserting a tag parent that will result in a tag being its own parent.
Right now, the trigger is tested, but not the actual migration (VScode tunnels can't tunnel QT apps sadly...), so if someone want to test before I get to it, feel free to do so
close: #1074
Tasks Completed