Skip to content

Commit

Permalink
[TASK] Use php-cs-fixer directly (#152)
Browse files Browse the repository at this point in the history
This change removes the package "typo3/coding-standards" in favour of
"friendsofphp/php-cs-fixer". There is no need to use this proxy package.

Instead, we define the needed rules directly. As we stick zu the PER-CS
standard (the successor of PSR-12) we pin the rules to the PER-CS 1
ruleset. Additionally, we opt in for some already implemented PER-CS 2
rules to avoid too much style changes already available in the codebase.

With the pinning to defined rules we ensure that updates of php-cs-fixer
does not "break" the currently used styles locally or in CI. Changes in
the defined rules can therefore be done explicitly.
  • Loading branch information
brotkrueml authored Nov 30, 2023
1 parent edf5306 commit be4a9cc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions resources/config/typo3-guides.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@

use phpDocumentor\Guides\Cli\Command\Run;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use T3Docs\GuidesExtension\Command\RunDecorator;

use function Symfony\Component\DependencyInjection\Loader\Configurator\service;

use T3Docs\GuidesExtension\Command\RunDecorator;

return static function (ContainerConfigurator $container): void {
$container->services()
->defaults()
Expand Down

0 comments on commit be4a9cc

Please sign in to comment.