Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of harmonic parameter's metadata #11

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Update of harmonic parameter's metadata #11

merged 2 commits into from
Apr 26, 2022

Conversation

fl0roth
Copy link
Collaborator

@fl0roth fl0roth commented Apr 4, 2022

Created a new metadata definition for the harmonic parameters which considers the wrapper and worker package structure.

@fl0roth fl0roth requested a review from marxt April 4, 2022 07:46
marxt
marxt approved these changes Apr 26, 2022
View reviewed changes
Copy link

@marxt marxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have a modification date, shoudn't there be entries for other modification related items e.g. software? Maybe not for this round but for discussion for future updates.

@fl0roth fl0roth merged commit 48ba470 into master Apr 26, 2022
@fl0roth fl0roth deleted the harmonic_update branch April 26, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marxt marxt marxt approved these changes

@cnavacch cnavacch cnavacch approved these changes

Assignees

@cnavacch cnavacch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl0roth @marxt @cnavacch