Big rewrite of swath/cell handlers, adding accessors #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems faster to filter swaths by just selecting desired grid points from each file rather than checking intersection with the bbox for each one and then reading again. Check with Pavan though, maybe he has a faster implementation
Not sure if I want to put logic for this on the individual CFDiscreteGeometry classes, since I believe it would be essentially the same on all of them - you always need to convert to point array before plotting. Also need to consider resampling to a raster vs. scatter-plotting, but I think this functionality could only be on the grid-aware accessor.
The logic for the out_dir filenames needs to be made more robust
Prior, gpi2cell returned a maskedarray but now it does not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edit a better description in here later, there are a lot of changes.