feat(runner/cleanup): start cleanup and vod sanity check action#1504
feat(runner/cleanup): start cleanup and vod sanity check action#1504joschahenningsen wants to merge 2 commits intodevfrom
Conversation
| err := r.runSingularAction(c, action, data, log, job) | ||
| if err != nil { | ||
| log.Error("action error", "error", err) // use action specific logger | ||
| if actions.IsAbortingError(err) { |
There was a problem hiding this comment.
I'm sorry if I am wrong but could this not lead to an infinite loop if an error is not an AbortingError? like when the ffmpeg command fails for other reasons?
| } | ||
| } else { | ||
| break // escape retry loop on no error | ||
| return // Action done without error |
There was a problem hiding this comment.
and here, if 'a' has multiple actions and the first action has no error, would it not just return the function without finishing the other actions? please let me know if I am wrong though
DawinYurtseven
left a comment
DawinYurtseven
left a comment
There was a problem hiding this comment.
everything that is new seems fine but the comments I'd like to at least know if it is intended for now or if they have been oversights (or if I am wrong)
|
after testing with grpcurl, it turns out that when the a job is created, the actions in the struct are not assigned to it, leaving to a access to nil error. I want to make sure if I am doing it right so:
my guess is that in the |
2 participants
Motivation and Context
Description
Steps for Testing
Prerequisites:
Screenshots