1032 option to make beta default mode #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Humphreys <[email protected]>
Signed-off-by: Matthew Humphreys <[email protected]>
Signed-off-by: Matthew Humphreys <[email protected]>
Signed-off-by: Matthew Humphreys <[email protected]>
Signed-off-by: Matthew Humphreys <[email protected]>
|
Your Testserver will be ready at https://1328.test.live.mm.rbg.tum.de in a few minutes. Logins
|
SebiWrn
requested changes
Apr 23, 2024
Signed-off-by: Matthew Humphreys <[email protected]>
SebiWrn
approved these changes
Apr 24, 2024
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* added api endpoint to update user setting Signed-off-by: Matthew Humphreys <[email protected]> * added frontend components to update user setting Signed-off-by: Matthew Humphreys <[email protected]> * watchPageData set according to user setting Signed-off-by: Matthew Humphreys <[email protected]> * removed some duplicate code Signed-off-by: Matthew Humphreys <[email protected]> * consistent spelling Signed-off-by: Matthew Humphreys <[email protected]> * make sure user is signed in Signed-off-by: Matthew Humphreys <[email protected]> --------- Signed-off-by: Matthew Humphreys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #1032.
Many users prefer the beta stream mode, so it makes sense for there to be a user option that makes this the default.
Description
Toggling the "Always use beta Stream when Available" option in the user settings will change the json value in the db for that user setting.
When the WatchPageData is being prepared this user setting is checked and if the default stream mode is set to beta, then the dvr value is set (in the same way it is if the URL contains the dvr query)
Steps for Testing
Prerequisites:
As for testing whether beta stream mode is actually used: that is something I cannot do locally.
Screenshots