Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update if skip silence button is shown on seek #1326

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Mjaethers
Copy link
Contributor

Motivation and Context

Fixes #1223.
When jumping backward or forwards in the video player the "Skip pause" button is not updated, meaning that pressing it after jumping forwards could take you back again. Or when jumping into a silent segment it is not possible to immediately jump to the end of it without first unpausing.

Description

The function that checks whether this button should be displayed is called whenever the user seeks (jumps backwards or forwards)

Steps for Testing

Prerequisites:

  • 1 Stream
  1. Log in
  2. Navigate to a Stream with silences
  3. Pause the Stream in a silent segment
  4. Jump past it, notice the "Skip pause" button vanishes
  5. Jump back into a silent segment, notice the button reappears

Screenshots

untitled.mp4

Copy link

github-actions bot commented Feb 4, 2024

Your Testserver will be ready at https://1326.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@SebiWrn SebiWrn self-requested a review April 23, 2024 15:48
@SebiWrn SebiWrn merged commit df9db01 into dev Apr 23, 2024
9 checks passed
@SebiWrn SebiWrn deleted the 1223-update-skip-silence-button-on-seek branch April 23, 2024 15:49
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the playback progress while paused causes the skip silence feature to work illogically
2 participants