Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melody config max message size increased #1324

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

fixes #1207

Description

melodyInstance := melody.New() creates a melody instance, which has a default config which has max message size is fixed to 512 bytes. That was increased to 1200. The text area, the user write their message has a max size 1000 and all the messages written there can be sent. That means limit is increased to 1000 for now. We decided to be 2000 chars at the meeting, the reason I let it stays as 1000 is that, different problems occur for messages longer than 1000 chars. I also wanted to add some warnings for longer messages and do some frontend changes because longer messages sometimes cause some visual problems. I want to open another issue for that and work on them here. This PR is just a short term solution for sending longer messages.

Steps for Testing

Prerequisites:
Admin or Lecturer rights

  1. Log in
  2. Create a new course with chat enabled and create a livestream to test the chat
  3. type a message longer than 400 chars, if you reach 1000 chars, the text are will not allow you to write anymore.
    Example 100 char random message:

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxfskjdfkjsdkcmsdkcmksdmcksdmcksdnvjbsdjvbsdjbvjsdbvjbsdjcvbnjsdkncksdaggckmsdkcmsdkmcksdxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxkkkkkkkkkkjjjjjjjjjjpppppppppp12345sdkj

Screenshots

The message above is sent and accepted by the channel:
long_text_msg

@SebiWrn
Copy link
Contributor

SebiWrn commented Mar 24, 2024

Maybe we can also add some number at the bottom of the chatbox with the current char count and the max char count?

@SebiWrn SebiWrn self-requested a review April 23, 2024 15:49
@SebiWrn SebiWrn merged commit bf2f11e into dev Apr 23, 2024
8 checks passed
@SebiWrn SebiWrn deleted the 1207-chat-cannot-send-messages-longer-than-385-characters-websocket-message-too-big branch April 23, 2024 15:49
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat cannot send messages longer than ~385 characters: Websocket message too big
2 participants