Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show watch progress in playlist view #1307

Merged

Conversation

Mjaethers
Copy link
Contributor

Motivation and Context

Closes #1248
Much how the watch progress of a recording is displayed on the thumbnail of a stream on the course page, the watch progress of a recording is displayed in the playlist view.

Description

The stream API now also passes the stream progress in the returned StreamPlaylistEntry object. This data is passed to the Typescript Progress class constructor allowing the html to call functions on the progress so that it can be rendered in the same manner as on the course page.

Steps for Testing

  1. Log in
  2. Navigate to a recording
  3. Blend in the playlist
  4. Notice the the thumbnails show a progress bar

Screenshots

Screenshot 2024-01-11 at 17-38-19 TUM-Live Einführung Brauereiwesen VL 2 Wie mache ich Bier

@YiranDuan721
Copy link
Contributor

I think this solution would work, but unfortunately at the moment it doesn't work correctly for me. The watch progress displayed in the playlist does not match the one on the course page (or the progress saved in database):
test_progress_in_playlist

Another small idea: I would like the width of the play progress not to exceed the width of the playlist, so that the playlist can be embedded perfectly in the page as it was, without the scrollbar at the bottom.

@Mjaethers
Copy link
Contributor Author

Interesting, this is a bug I thought I had fixed, but I suppose I wasn't rigorous enough with different browsers and windows sizes. Thanks for looking into this, I'll try to fix it as soon as I have the time to.

@YiranDuan721
Copy link
Contributor

YiranDuan721 commented Jan 18, 2024

Ooops, it turns out that was due to me forgetting to clear the browser cache before testing. After that it works perfectly.

Sorry, my bad!

Copy link
Contributor

@YiranDuan721 YiranDuan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me locally :)

Copy link
Contributor

@YiranDuan721 YiranDuan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem ;)

@YiranDuan721
Copy link
Contributor

YiranDuan721 commented Jan 18, 2024

I'm not sure about the failing check. It seems to be concerning some problem with user authentification? To test about that, also to trigger the test server deploying test again, I will push one commit here.
I'm not sure, but I think you can directly work on this repository, instead of the forked one, to avoid this problem

@YiranDuan721 YiranDuan721 merged commit 49587e1 into TUM-Dev:dev Jan 18, 2024
7 of 8 checks passed
@Mjaethers
Copy link
Contributor Author

Okay thanks. I'll try without a fork next time, that might be it.

SebiWrn pushed a commit that referenced this pull request May 7, 2024
* pass progress to StreamPlaylistEntry

* correct padding

* linted formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show watch progress in playlist view
2 participants