-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show watch progress in playlist view #1307
Show watch progress in playlist view #1307
Conversation
Interesting, this is a bug I thought I had fixed, but I suppose I wasn't rigorous enough with different browsers and windows sizes. Thanks for looking into this, I'll try to fix it as soon as I have the time to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected for me locally :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem ;)
|
Okay thanks. I'll try without a fork next time, that might be it. |
* pass progress to StreamPlaylistEntry * correct padding * linted formatting
Motivation and Context
Closes #1248
Much how the watch progress of a recording is displayed on the thumbnail of a stream on the course page, the watch progress of a recording is displayed in the playlist view.
Description
The stream API now also passes the stream progress in the returned StreamPlaylistEntry object. This data is passed to the Typescript Progress class constructor allowing the html to call functions on the progress so that it can be rendered in the same manner as on the course page.
Steps for Testing
Screenshots