1094 list view in new UI #1286
Merged
1094 list view in new UI #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added boolean to commandBuild and lowered probesize a bit to see if it works now * Removed checks for isSelfStream because not used * Removed deprecated for isSelfStream * Set isSelfStream to true for selfstreams * added boolean to commandBuild and lowered probesize a bit to see if it works now --------- Co-authored-by: Dawin Yurtseven <[email protected]>
* popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]>
Closed
|
Your Testserver will be ready at https://1286.test.live.mm.rbg.tum.de in a few minutes. Logins
|
SebiWrn
commented
Dec 29, 2023
|
Currently, the status of whether the list view is displayed is reset when the page is accessed again. I would prefer it to be preserved like the other options. I can see that the state "listView" is indeed preserved in the browser's local storage, but it doesn't look like it's being restored properly when the page loads or reloads. |
|
Thank you for your feedback, problem should be fixed now :) |
changed if else writing style
SebiWrn
added a commit
that referenced
this pull request
May 7, 2024
* Added list view -> not finished yet * Enh/transcoding issues (#1283) * added boolean to commandBuild and lowered probesize a bit to see if it works now * Removed checks for isSelfStream because not used * Removed deprecated for isSelfStream * Set isSelfStream to true for selfstreams * added boolean to commandBuild and lowered probesize a bit to see if it works now --------- Co-authored-by: Dawin Yurtseven <[email protected]> * popup chat close on esc added. (#1281) * popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]> * Set GIN to only log above level 400 (#1271) * Show worker version on worker dashboard (#1285) * Updated storage * Lint fix * Update course.ts changed if else writing style * Lint fix --------- Co-authored-by: Dawin Yurtseven <[email protected]> Co-authored-by: barisgul15 <[email protected]> Co-authored-by: Dawin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds a List View to the course view.
Description
You can now switch between the thumbnail and list view in the course page.
Steps for Testing
Prerequisites:
Screenshots
Default View:
List View:
