Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch page: Align sidebars with the watch wrapper #1251

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

YiranDuan721
Copy link
Contributor

@YiranDuan721 YiranDuan721 commented Dec 4, 2023

closes #1249

Change 1: margin of the sidebars

Before:

After:

Change 2: height of the sidebars when the page is wide but short

Before:

After:

…se when the page size is wide but not high enough. No margin at the top of the sidebars (fixes #1249)
…r in case when the page size is wide but not high enough.
Copy link

github-actions bot commented Dec 4, 2023

Your Testserver will be ready at https://1251.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@SebiWrn SebiWrn merged commit c64f3ea into dev Dec 13, 2023
9 checks passed
@SebiWrn SebiWrn deleted the front-end/watch-page branch December 13, 2023 15:01
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* watch page: Align the height of sidebars with the watch wrapper in case when the page size is wide but not high enough. No margin at the top of the sidebars (fixes #1249)

* watch page: Align the height of streams-sidebar with the watch wrapper in case when the page size is wide but not high enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist misaligned
2 participants