Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1171 seeking 15 second is too long #1234

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

Issue: #1171
The seeking time of a video was set to 15 second and it can not be changed. Sometimes to hear what just said 15 seconds can be too much.

Description

There used to be no user setting option related with seeking. Now the seekingTime is also added to the user settings. A button to choose the seeking time is added to the settings page of user. It is still set to 15 seconds as default, but now the user has also the options of 5 or 10 seconds a seeking Time. When the popular video platform on the web are examined, the general seeking options were 5, 10 and 15 seconds. Therefore there is no more option is added, but can always be added just by expanding the button because backend is already set. The option of whether allowing user to write his/her own seeking time can be discussed, but thought that these three options are enough to solve the issue and also giving concrete options in a rather small matter seemed more appropriate.

The created button changes the new user setting SeekingTime. For seeking then the new value is used. Since user settings can store a value as a String, the conversion from String to a number/int was done in the backend, not in the frontend of the code. It is chosen so, because the same method is also used for playbackspeeds and making this conversion on the backend seemed more robust.

For getSeekTime and updateSeekTime methods, the already implemented get and update methods of the other user settings are considered and these methods were created accordingly.

Steps for Testing

Prerequisites:
Having a tumlive account

  1. Log in
  2. Navigate to settings
  3. Change the seeking time
  4. Navigate a live stream or to an already published video
  5. Seek the video and see if it seeks 15 seconds or accordingly to what was chosen in settings
  6. Log out
  7. Log in again and control if the seeking time was still set to the same value you have chosen before

Screenshots

Settings_wit_Seeking_Tİme

@barisgul15 barisgul15 linked an issue Nov 13, 2023 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1234.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@MariusAlbrecht
Copy link

I am not really involved in the project and more like a user but I do have two suggestions:

  • change "seconds" to "s" or move the unit straight to the title. To me the current way feels cluttered
  • add more options. Doesn't really have a downside, does it? (especially combined with the other suggestion)

@hmelder
Copy link

hmelder commented Dec 5, 2023

add more options. Doesn't really have a downside, does it? (especially combined with the other suggestion)

PRs are welcome!

@barisgul15
Copy link
Contributor Author

I am not really involved in the project and more like a user but I do have two suggestions:

  • change "seconds" to "s" or move the unit straight to the title. To me the current way feels cluttered
  • add more options. Doesn't really have a downside, does it? (especially combined with the other suggestion)

For the first point, i will look into it. Aesthetics is definitely not my strong point and i am open to every suggestion. For the second point, it is really easy to add more options, because seeking time is already added as user setting and it will be given the value user choses, so what just adding new options on html code will be enough. But do someone needs more than these? I assume that by more options you meant more than 15 seconds, but does someone ever needs to seek a video more than 15 seconds?

@SebiWrn SebiWrn enabled auto-merge (squash) January 11, 2024 17:00
@SebiWrn SebiWrn self-requested a review January 11, 2024 17:01
@SebiWrn SebiWrn merged commit 96f53da into dev Jan 11, 2024
8 checks passed
@SebiWrn SebiWrn deleted the 1171-seeking-15-second-is-too-long branch January 11, 2024 17:02
SebiWrn added a commit that referenced this pull request May 7, 2024
* SeekingTime enum is created for posting the request.

* Seeking time user setting and selection button are added.

* front-end changes and 20s seeking time options is added.

* Updated file

* Updated error messages

* Fixed golangci

* Ran gofmt -s -w on all files

* Ran gofumpt -l -w

* Update live_update.go

* Fixed some bugs caused from gofumpt

* Fixed a bug

---------

Co-authored-by: Sebastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeking 15 seconds is too long
4 participants