Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1214 playback at t 0 #1224

Closed
wants to merge 5 commits into from
Closed

1214 playback at t 0 #1224

wants to merge 5 commits into from

Conversation

YiranDuan721
Copy link
Contributor

Motivation and Context

fixed #1214

Description

Distinguish the behavior of the watchProgress function when the parameter t is set to 0 and when it is not set, so that it matches the description in the comment:

If query parameter 't' is specified, the timestamp given by 't' will be used.

Steps for Testing

  1. Clear website cache
  2. Log in
  3. Navigate to a recording video
  4. Jump to anywhere in the video other than the start
  5. Refresh the page, note that the watch progress has been recorded and can be restored, so that the video resumes at the last progress
  6. Add parameter "t=0" to current url and visit it
  7. See the video plays from the start

@github-actions
Copy link

Your Testserver will be ready at https://1224.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself looks good! However, I would not like to check in the go.work.sum file here. I did not inspect the go.work.sum file in detail, but it seems odd to me that so many lines are added, although there should be no dependency updates.

@YiranDuan721
Copy link
Contributor Author

Thanks for the review! I can't find a way to revert the change to "go.work.sum" file elegantly -- I'll just create a new branch and do the things again. Sorry for the bother, I'll be more careful with git next time.
:pingubonk:

@YiranDuan721 YiranDuan721 deleted the 1214_playback_at_t_0 branch November 8, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback using link with t=0 does not work
2 participants