Prolong maximum chat message length to 1000 characters #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschahenningsen
requested changes
Aug 23, 2023
|
BTW, there also is server side validation: https://github.com/joschahenningsen/TUM-Live/blob/dev/model/chat.go#L40 |
|
Alright, thanks – I was already wondering, but the server accepted messages with ~220 characters and did not find any other occurence of "200" related to chat messages, so I assumed there was no server-side check. |
I can't think of any reason why we would have done this on purpose. I assume it was just an oversight. |
Merged
alexanderstephan
pushed a commit
that referenced
this pull request
Aug 30, 2023
In #1135 the textarea tag hasn't been closed. As a result the chat UI doesn't work properly. Furthermore, it broke the polls. This is fixed by closing the tag.
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Prolong maximum chat message length to 1000 characters * Fix ESLint and server-side check
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
In #1135 the textarea tag hasn't been closed. As a result the chat UI doesn't work properly. Furthermore, it broke the polls. This is fixed by closing the tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We want longer chat messages! I can't answer to the questions of our students if I'm not able to write a long prose with at least 800 characters! :-P
Resolves #778.
Description
I replaced the chat input box with a multiline text area and extended the maximum message length from 200 to 1000 characters.
Steps for Testing