fix duration on video thumbnails #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1132.test.live.mm.rbg.tum.de in a few minutes. Logins
|
joschahenningsen
requested review from
MatthiasReumann,
alexanderstephan and
mono424
MatthiasReumann
approved these changes
Aug 22, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* fix duration on video thumbnails * remove unneccessary imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current duration in only approximated based on the planned times of the lectures. Instead, we should use the duration stored in the database to accurately display the video duration.
Additionally, the current frontend renders the time based on the locale of the browser, which leads to weird behavior like
03:00:00 AM(see screenshot)Screenshots
Before
After