Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display lecture time in vod title, if stream name not present #1092

Merged
merged 1 commit into from
Jul 26, 2023
Merged

display lecture time in vod title, if stream name not present #1092

merged 1 commit into from
Jul 26, 2023

Conversation

simon300000
Copy link
Contributor

@simon300000 simon300000 commented Jul 26, 2023 •
edited
Loading

Motivation and Context

blank title with : looks bad

Description

I put Lecture: D M, Y there

Steps for Testing

Prerequisites:

  • Web Browser
  1. Navigate to a VOD without name
  2. notice the title is different

Screenshots

屏幕截图 2023-07-26 211027

joschahenningsen
joschahenningsen approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix! 🍻

@joschahenningsen joschahenningsen merged commit 028bbbf into TUM-Dev:dev Jul 26, 2023
6 of 8 checks passed
SebiWrn pushed a commit that referenced this pull request May 7, 2024
@simon300000 @SebiWrn
display lecture time in vod title (#1092)
bbeb20b
@simon300000 simon300000 deleted the vod-title-fix branch May 9, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschahenningsen joschahenningsen joschahenningsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon300000 @joschahenningsen