Video Section Component #1084
Merged
Video Section Component #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1084.test.live.mm.rbg.tum.de in a few minutes. Logins
|
MatthiasReumann
commented
Jul 17, 2023
web/ts/video/watchers.ts
Outdated
There was a problem hiding this comment.
Copied from #1071.
MatthiasReumann
requested review from
joschahenningsen,
mono424 and
alexanderstephan
alexanderstephan
approved these changes
Aug 16, 2023
# Conflicts: # web/assets/css/home.css # web/template/watch.gohtml # web/ts/video/watchers.ts
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Add VideoSectionAPI; Reutilize ts utilities * Add slidingWindow and Time * Add watchers * Update highlight search * Add back follow sections * Remove old code * Update css * Update mobile css * Small css changes * Uncomment chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Due to the implementation of other components, most of the custom-built functionality for video sections is redundant. This PR addresses this issue.
Description
Add video section component. Remove redundant code. Use start page CSS classes.
Steps for Testing
Screenshots