-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Section Component #1084
Video Section Component #1084
Conversation
Your Testserver will be ready at https://1084.test.live.mm.rbg.tum.de in a few minutes. Logins
|
web/ts/video/watchers.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from #1071.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me! 🎉 After the merge, this is good to go IMO.
# Conflicts: # web/assets/css/home.css # web/template/watch.gohtml # web/ts/video/watchers.ts
* Add VideoSectionAPI; Reutilize ts utilities * Add slidingWindow and Time * Add watchers * Update highlight search * Add back follow sections * Remove old code * Update css * Update mobile css * Small css changes * Uncomment chat
Motivation and Context
Due to the implementation of other components, most of the custom-built functionality for video sections is redundant. This PR addresses this issue.
Description
Add video section component. Remove redundant code. Use start page CSS classes.
Steps for Testing
Screenshots