bug Delete Chat Replies on Delete
#1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasReumann
requested review from
mono424,
alexanderstephan and
joschahenningsen
|
Your Testserver will be ready at https://1064.test.live.mm.rbg.tum.de in a few minutes. Logins
|
mono424
approved these changes
Jun 13, 2023
Probably not. Good idea! 👍🏻 |
|
Please ignore the |
joschahenningsen
requested changes
Jun 14, 2023
dao/chat.go
Outdated
Comment on lines
167
to
169
| return errors.Join( | ||
| DB.Model(&model.Chat{}).Delete(&model.Chat{}, id).Error, | ||
| DB.Delete(&model.Chat{}, "reply_to = ?", id).Error) |
There was a problem hiding this comment.
This seems a little cleaner
Suggested change
| return errors.Join( | |
| DB.Model(&model.Chat{}).Delete(&model.Chat{}, id).Error, | |
| DB.Delete(&model.Chat{}, "reply_to = ?", id).Error) | |
| return DB.Where("id = ? OR reply_to = ?", id, id).Delete(&model.Chat{}).Error |
# Conflicts: # go.work.sum
joschahenningsen
approved these changes
Jun 21, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Add DeleteReplies * Fix tests * Merge functions * Update dao function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently if a message with replies is deleted only the "base" message is deleted, i.e. replies are kept in the database. In other words
deleted_atis only not-null for base messages. As a consequence, each time we fetch messages deleted "ghost" replies are transmitted also.This PR fixes this issue.
Description
Add
DeleteRepliestoChatDaoand call in delete handler.Steps for Testing