Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VOD not working if path != /vod/ #1061

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

mono424
Copy link
Collaborator

@mono424 mono424 commented Jun 11, 2023

Motivation and Context

Previously, the VOD (Video on Demand) feature was only accessible through the specific VOD-Path /vod. If any other path was used, the content delivery edge would respond with a 404 error. This limitation prevented users from customizing their VOD paths according to their preferences. The motivation behind the recent changes was to resolve this issue and allow developers to specify custom VOD paths.

Description

  • Previously, if a path other than /vod was used, the system responded with a 404 error. This has been fixed, and the system will now recognize and handle custom VOD paths appropriately.
  • JWT Check was only working if the path was /vod. Now it's working for custom paths as well.

Steps for Testing

Prerequisites:

  • 1 Lecturer
  • 1 Course
  1. Log in
  2. Navigate to a course management page
  3. Create a new Video-on-Demand
  4. Check if the Video-on-Demand is accessible
  5. Change the VoD-Path on your local environment ()
  6. Create a new Video-on-Demand
  7. Check if the Video-on-Demand is accessible

Screenshots

@github-actions
Copy link

Your Testserver will be ready at https://1061.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@mono424 mono424 marked this pull request as ready for review June 11, 2023 20:06
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@joschahenningsen joschahenningsen merged commit 3d3bf66 into dev Jun 11, 2023
@joschahenningsen joschahenningsen deleted the feature/enable-non-root-path-for-vod branch June 11, 2023 20:13
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* trim the right url path

* using url path also in jwt check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants