Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-clicking on new start page #1048

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Currently you can't right-click > open in new tab on the new start page. This PR fixes this.

Description

Use <a :href="" @click.prevent=""> instead of <button>

Steps for Testing

1 Account

  1. Log in
  2. Right click courses on the side navigation and open in new tab
  3. Normal click courses on the side navigation
  4. Right click on the course of one livestreams and open in new tab
  5. Normal click on the course of one livestream
    1. Right click on the course of one VOD and open in new tab
  6. Normal click on the course of one VOD

@github-actions
Copy link

Your Testserver will be ready at https://1048.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@mono424
Copy link
Collaborator

mono424 commented May 29, 2023

Works like charm 👍

@MatthiasReumann MatthiasReumann merged commit d7ef64e into dev May 30, 2023
@MatthiasReumann MatthiasReumann deleted the enh/new-start-page-rightclick branch May 30, 2023 05:23
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants