Live viewer count #1037
Merged
Live viewer count #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1037.test.live.mm.rbg.tum.de in a few minutes. Logins
|
api/courses.go
Outdated
| @@ -154,10 +155,14 @@ func (r coursesRoutes) getLive(c *gin.Context) { | |||
| lectureHall = &lh | |||
| } | |||
| } | |||
|
|
|||
| var stat model.Stat | |||
| stat, err = r.StatisticsDao.GetStat(stream.ID) | |||
There was a problem hiding this comment.
We should be able to just get this number from memory. The length of the chat session contains the number of viewers: https://github.com/joschahenningsen/TUM-Live/blob/a1c9209f5a875eab2967035d742ecab0b2e56fac/api/chat.go#LL661C43-L661C43
Would this be easier to implement and more efficient?
There was a problem hiding this comment.
Definitely. 👍🏻 However, we need to make sure to update this if we ever shard and distribute the chat as in #889.
joschahenningsen
approved these changes
May 24, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Add live view count * Fix tests * Use len(chat-sessions) instead of db query * Regenerate mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves #1026
Description
Steps for Testing
/newScreenshots