Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the STAR output as bam file #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Define the STAR output as bam file #14

wants to merge 3 commits into from

Conversation

LKress
Copy link
Contributor

@LKress LKress commented Jul 22, 2024

The STAR output file has to be a BAM file and no SAM file.

@LKress LKress requested a review from priesgo July 22, 2024 10:08
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder why this was not a problem before. I could only improve this by checking that the format is right in the output of integration tests.

@LKress
Copy link
Contributor Author

LKress commented Jul 22, 2024

@priesgo I will check this further.
In my previous PR I did not consider the changed file ending when running STAR with the default outSAMtype parameter. Thus BAM file format is now forced. In the integration test, the output filename remains the same, as the file is renamed in the STAR process.

@priesgo
Copy link
Collaborator

priesgo commented Jul 22, 2024

Yup, I understand. You could check that it's a valid BAM with samtools. You would need to install it in the CI environment though, but that should be a piece of cake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants