Skip to content

Accum #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: unstable
Choose a base branch
from
Open

Accum #967

wants to merge 17 commits into from

Conversation

dominikkiese
Copy link
Contributor

Reopening of #966

@dominikkiese dominikkiese mentioned this pull request Sep 26, 2024
Closed
@Wentzell
Copy link
Member

Thank you @dominikkiese for this improvement! I pushed some simplifications in my commit ffb12cc

Can you please look into creating a test of the callback functionality?

@dominikkiese
Copy link
Contributor Author

Commit looks good to me, using nda::map with the abs_square function makes the code much more compact! I will think about a proper test.

@Wentzell Wentzell force-pushed the ACCUM branch 2 times, most recently from 227eb6a to 555eaf7 Compare April 21, 2025 16:23
dominikkiese and others added 15 commits July 25, 2025 15:22
@dominikkiese @Wentzell
[stat] Add callback function to accumulator, consistently use nda::ha…
a6e6eed 
…damard
@Wentzell
[stat] Simplify accumulator callback construction, add abs_square fun…
88092f7 
…ction to simplify code
@Wentzell
[stat] Callback in linear binner should be called before compression
af58a63
@Thoemi09 @Wentzell
Rename make_real.hpp to utils.hpp, add more utils and tests
a097aae
@Thoemi09 @Wentzell
Clean up in mean_error.hpp and in the corresponding tests
e9f14fc
@Thoemi09 @Wentzell
Move lin_binning and log_binning out of detail namespace into their o…
a459faf 
…wn file
@Thoemi09 @Wentzell
Clean up lin_binning.hpp and add new tests
a698663
@Thoemi09 @Wentzell
Clean up log_binning.hpp and add new tests
cd3b5af
@Thoemi09 @Wentzell
Clean up jackknife.hpp and add new tests
1ec249e
@Thoemi09 @Wentzell
Clean up histograms.hpp/.cpp and update tests
033c80d
@Thoemi09 @Wentzell
Add some additional tests to triqs/stat
d7100d8
@Thoemi09 @Wentzell
Remove accumulator.hpp and various tests in triqs/stat
2fe7a30
@Thoemi09 @Wentzell
Fix compilation error due to recent changes in mpi
e650955
@Thoemi09 @Wentzell
Fix bug in stat/histogram.hpp
99af5e5
@Thoemi09 @Wentzell
Fix UB behavior in stat tests
d07098f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parcollet parcollet Awaiting requested review from parcollet

@Wentzell Wentzell Awaiting requested review from Wentzell

@Thoemi09 Thoemi09 Awaiting requested review from Thoemi09

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominikkiese @Wentzell @Thoemi09