Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme #134

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Updated readme #134

merged 2 commits into from
Dec 10, 2023

Conversation

scemama
Copy link
Member

@scemama scemama commented Dec 7, 2023

I rewrote a few things in the readme.
I changed

make -j`getconf _NPROCESSORS_ONLN`

because I think it was unnecessarily complicated. Also, I think that when you run with a very large number of cores, the Fortran module might not be compiled when expected. I put make -j 4 because it is more deterministic.

Also, I added a section to specify that people can distribute TREXIO with their codes, and that they should use the release tarballs.

@q-posev
Copy link
Member

q-posev commented Dec 9, 2023

getconf _NPROCESSORS_ONLN is the only portable unix solution i could find. Having a fixed number is ok too.

For your prefix additions, you can specify that it's just a recommendation to use .local. The user should have the full freedom of choosing the installation prefix.

@scemama
Copy link
Member Author

scemama commented Dec 9, 2023

OK, thanks, I rewrote that part.

@q-posev q-posev self-requested a review December 10, 2023 11:46
@q-posev q-posev merged commit d67f124 into master Dec 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants