CMake compilation as a subdirectory #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
when compiling trexio with CMake as a subdirectory of a larger project, e.g. with the following structure:
Project/
src/
external/
trexio/
including trexio in the root CMakeLists.txt as
add_subdirectory(external/trexio)
hasCMAKE_SOURCE_DIR
pointing toProject
instead ofProject/external/trexio
which breaks functionality. It is fixed by usingPROJECT_SOURCE_DIR
instead, which is identical toCMAKE_SOURCE_DIR
if trexio is installed on its own.Furthermore, I made
FindTREXIO.cmake
check whetherTREXIO_DIR
is set as a CMake variable before loading it from the environment variable.