Fix CleanupRefactoring queuing duplicate rewrites for the same node - #177
Open
FrancescoPezzella wants to merge 3 commits into
Open
FrancescoPezzella wants to merge 3 commits into
FrancescoPezzella wants to merge 3 commits into
Conversation
FrancescoPezzella
marked this pull request as draft
September 11, 2026 15:20
FrancescoPezzella
force-pushed
the
fix-cleanup-refactoring-dupe
branch
from
September 11, 2026 15:57
6d6a160 to
66b2132
Compare
Collaborator
|
@rcorvino The root cause of this issue is your change on line 15 of renaissance/recipes/cleanup_refactoring.py - refs = flatten(find_ast_type(n, VariableDef) for n in find_ast_type(ast_refactor.node, CompoundStatement))
+ refs = flatten(
+ find_semantic_kind(n, SemanticKind.DECLARATION) for n in find_semantic_kind(ast_refactor.node, SemanticKind.STATEMENT)
+ )As after this change a declaration will be added twice - once as part of the compound statement (that is the body of a function) and once as part of the declaration statement. When navigation to the parent would be available, one can check for the direct containment and solve the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#176