-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eud flow prep #1
base: main
Are you sure you want to change the base?
Conversation
…ethods Refactor OpenId4VPService Refactor to use more safe input Mark properties that are mdoc specific Refactor initialization of BlePresentationService Refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Julian! Please don't merge for now. We can use a temporary base branch that is different from main
until we decide when to request merging of specific parts in the parent repo.
func getAuthorizationCode(requestURL: URL) async throws -> String? | ||
} | ||
|
||
public class OpenId4VciUserAuthorizationServiceDefault: NSObject, OpenId4VciUserAuthorizationService, ASWebAuthenticationPresentationContextProviding { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I prefer a naming scheme like Default...Service
for better readability in Code. So I can distinguish between the implementation and protocol very quickly. What do you think?
No description provided.