Merge pull request #12 from torresashjian/test_engine_worker

Add worker tests

engine/runner/worker.go

@@ -2,6 +2,7 @@ package runner
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/TIBCOSoftware/flogo-lib/core/action"
 )
@@ -78,6 +79,12 @@ func (w ActionWorker) Start() {
 				log.Debugf("worker-%d: Received Request\n", w.ID)
 
 				switch work.ReqType {
+				default:
+
+					err := fmt.Errorf("Unsupported work request type: '%d'", work.ReqType)
+					actionData := work.actionData
+					actionData.rc <- &ActionResult{err: err}
+
 				case RtRun:
 
 					actionData := work.actionData

engine/runner/worker_test.go

@@ -0,0 +1,86 @@
+package runner
+
+import (
+	"errors"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
+	"testing"
+)
+
+//TestWorkerInvalidRequestType worker returns error for invalid request type
+func TestWorkerInvalidRequestType(t *testing.T) {
+	worker := createDefaultWorker()
+	worker.Start()
+
+	rc := make(chan *ActionResult)
+	actionData := &ActionData{rc: rc}
+
+	// Create some work
+	invalidWorkRequest := ActionWorkRequest{ReqType: -1, actionData: actionData}
+
+	// Send some work
+	worker.Work <- invalidWorkRequest
+
+	// Check work result
+	result := <-actionData.rc
+
+	assert.NotNil(t, result.err)
+	assert.Equal(t, "Unsupported work request type: '-1'", result.err.Error())
+}
+
+//TestWorkerErrorInAction returns an error when the action returns error
+func TestWorkerErrorInAction(t *testing.T) {
+	worker := createDefaultWorker()
+	worker.Start()
+
+	rc := make(chan *ActionResult)
+
+	action := new(MockFullAction)
+	action.On("Run", nil, mock.AnythingOfType("string"), nil, mock.AnythingOfType("*runner.AsyncResultHandler")).Return(errors.New("Error in action"))
+
+	actionData := &ActionData{rc: rc, action: action}
+
+	// Create some work
+	errorWorkRequest := ActionWorkRequest{ReqType: RtRun, actionData: actionData}
+
+	// Send some work
+	worker.Work <- errorWorkRequest
+
+	// Check work result
+	result := <-actionData.rc
+
+	assert.NotNil(t, result.err)
+	assert.Equal(t, "Error in action", result.err.Error())
+}
+
+//TestWorkerStartOk
+func TestWorkerStartOk(t *testing.T) {
+	worker := createDefaultWorker()
+	worker.Start()
+
+	rc := make(chan *ActionResult)
+
+	action := new(MockResultAction)
+	action.On("Run", nil, mock.AnythingOfType("string"), nil, mock.AnythingOfType("*runner.AsyncResultHandler")).Return(nil)
+
+	actionData := &ActionData{rc: rc, action: action}
+
+	// Create some work
+	okWorkRequest := ActionWorkRequest{ReqType: RtRun, actionData: actionData}
+
+	// Send some work
+	worker.Work <- okWorkRequest
+
+	// Check work result
+	result := <-actionData.rc
+
+	assert.Nil(t, result.err)
+	assert.NotNil(t, result)
+	assert.Equal(t, "mock", result.data)
+}
+
+func createDefaultWorker() ActionWorker {
+	runner := NewDirect()
+	queue := make(chan chan ActionWorkRequest, 2)
+	return NewWorker(1, runner, queue)
+}