Handle non existent commands during development#214
Open
xLuxy wants to merge 1 commit into
Open
Conversation
xLuxy
force-pushed
the
features/command-improvement
branch
from
28cb601 to
288d210
Compare
|
xLuxy
changed the title
Contributor
|
Iirc #210 partially already handles this, but I'd say this should expand on what I did in that PR well so PR is still valid. |
|
PASS YOUR CI BUDDY |
Contributor
This CI failing is related to something else inside of the repo main already not related to this PR. |
LGTM 👍 |
marquisburg
approved these changes
Jun 5, 2026
marquisburg
left a comment
marquisburg
left a comment
There was a problem hiding this comment.
Other than the 2 comments that are redundant, logically LGTM.
| private async handle_slash_comand(interaction: Discord.ChatInputCommandInteraction) { | ||
| if (!(interaction.commandName in this.text_commands)) { | ||
| // TODO: Unknown command | ||
| // unknown command |
| @@ -134,6 +134,13 @@ export class CommandHandler { | |||
| const command_name = match[1]; | |||
| if (!(command_name in this.text_commands)) { | |||
| // unknown command | |||
There was a problem hiding this comment.
Redundant comment, special case below in diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
freestandingis set totrueand you try to use a command which is not registered the bot will throw an exception. (I've used themodlogscommand for testing)This PR fixes that by adding a missing return statement.
As a small improvement to this, i've also added a response to whenever a command has not been registered which can help during development.
Context: