show an example of gin middleware for authorization and authentication #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
requested review from
decentralgabe,
nitro-neal and
andresuribe87
as code owners
michaelneale
changed the title
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 20.00% 20.00%
=======================================
Files 50 50
Lines 6175 6175
=======================================
Hits 1235 1235
Misses 4712 4712
Partials 228 228 |
decentralgabe
requested changes
Jun 21, 2023
There was a problem hiding this comment.
I don't think we should add this to the main codeline, I'm fine with it living in an examples directory for extension.
I'm not certain we should add any auth, let alone user-based auth like this. If we do add auth I'd favor a DID-auth based solution. Until we have requirements, a design, and some consensus let's hold off on this.
|
@decentralgabe yeah can be in examples/docs for sure. I think there needs to be flexibility for implementers. Is there did based auth already in there? |
|
no DID auth yet, we have a ticket to track TBD54566975/ssi-sdk#306 |
vlad-tim
pushed a commit
to vlad-tim/ssi-service
that referenced
this pull request
Jun 23, 2023
TBD54566975#551) * show an example and document gin middleware for authorization and authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implementers of an ssi-service may want to weave in authentication and authorization.
Description
This shows how it can be done with stubbed out code which can be modified as needed.
There isn't an easy runtime plugin mechanism for golang so this would likely be done by the implementer.
How Has This Been Tested?
Regression tests covers this as it adds no functionality.
References
https://github.com/gin-gonic/gin/blob/master/docs/doc.md#using-basicauth-middleware