Remove returning private keys #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 20.43% 20.48% +0.05%
==========================================
Files 48 48
Lines 5423 5385 -38
==========================================
- Hits 1108 1103 -5
+ Misses 4140 4108 -32
+ Partials 175 174 -1
|
andresuribe87
approved these changes
May 9, 2023
| KeyType: createDIDResponse.KeyType, | ||
| } | ||
|
|
||
| resp := CreateDIDByMethodResponse{DID: createDIDResponse.DID} |
There was a problem hiding this comment.
Is it possible to:
- Remove the fields you deleted from the
CreateDIDByMethodResponse? - Update the documentation of this endpoint, particularly the description? From the perspective of a dev using ssi-service, it's important to understand what happens to the keys when this method is called.
There was a problem hiding this comment.
- yes - done
- yes will update good call
* tmp * remove side effects; use sdk lib * update issuance template * temp * temp * pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371