Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add IconButton Component #1636

Merged
merged 11 commits into from
Sep 19, 2024
Merged

✨ add IconButton Component #1636

merged 11 commits into from
Sep 19, 2024

Conversation

FahadAminShovon
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Resolves #

Mobile & Desktop Screenshots/Recordings

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for tbd-website-developer-new ready!

Name Link
🔨 Latest commit 197419d
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer-new/deploys/66ec2c925a1b5d0008315679
😎 Deploy Preview https://deploy-preview-1636--tbd-website-developer-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for tbd-website-developer ready!

Name Link
🔨 Latest commit 197419d
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer/deploys/66ec2c927e23a00008bb0344
😎 Deploy Preview https://deploy-preview-1636--tbd-website-developer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dayhaysoos dayhaysoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button itself seems great, but I'm double checking with the design team if the intention was for the buttons to be standalone components or if "component" meant the entire thing, like this for example:

Screenshot 2024-09-17 at 6 11 46 PM

FahadAminShovon and others added 10 commits September 19, 2024 01:34
* Kicking off CodeBlock prism config

* removing unused themes

* Add url to codeblocks documentation
* external contributors page

* adding GH action

* updating json file name

* adding issue template

* add tania as reviewer in GH action

* from buttons -> check boxes

* adjust name & link from community page

* add issue link

---------

Co-authored-by: Nick DeJesus <[email protected]>
Co-authored-by: Angie Jones <[email protected]>
@dayhaysoos dayhaysoos merged commit 6d10b49 into main Sep 19, 2024
16 checks passed
@dayhaysoos dayhaysoos deleted the icon-button-component branch September 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants